]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
viewSelector: Make sure it's invisible when overview is hidden
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 2 Jun 2020 17:21:02 +0000 (14:21 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 3 Jun 2020 15:55:45 +0000 (12:55 -0300)
Instead of overriding the hide() method, use the vfunc to
reset, and hide the workspaces display too.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

js/ui/viewSelector.js

index 3ec97b1cf3bd773e438506b6160eb0b47a89a825..aefe806a8433995198a8ada924a68d1d9a344c45 100644 (file)
@@ -132,6 +132,7 @@ var ViewSelector = GObject.registerClass({
         super._init({
             name: 'viewSelector',
             x_expand: true,
+            visible: false,
         });
 
         this._showAppsButton = showAppsButton;
@@ -272,6 +273,7 @@ var ViewSelector = GObject.registerClass({
     }
 
     animateToOverview() {
+        this.show();
         this.reset();
         this._workspacesDisplay.animateToOverview(this._showAppsButton.checked);
         this._activePage = null;
@@ -301,9 +303,11 @@ var ViewSelector = GObject.registerClass({
         this._workspacesDisplay.setWorkspacesFullGeometry(geom);
     }
 
-    hide() {
+    vfunc_hide() {
         this.reset();
         this._workspacesDisplay.hide();
+
+        super.vfunc_hide();
     }
 
     _addPage(actor, name, a11yIcon, params) {